Add confirmation modals to destructive actions #270
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Info
Closes #171
For most destructive buttons, including ones directly cause API actions when clicked, as well as some other permanent actions like competing a pickup event, it now asks for confirmation first.
Background: a pickup event was accidentally marked as completed
Changes
useConfirm
hook that manages a confirmation modalType of Change
expected)
linting/formatting)
workflows)
Testing
I have tested that my changes fully resolve the linked issue ...
Checklist
/src/lib/*
and commented hard to understand areasanywhere else.
Screenshots
^ note: i'm not sure if the backend does delete all of a collections' items
this one has a different cancel button label to avoid the double cancel:
![image](https://private-user-images.githubusercontent.com/22133785/389422695-4bcfdcee-71b4-42d1-a5ce-2e8d0040ff1f.png?jwt=eyJhbGciOiJIUzI1NiIsInR5cCI6IkpXVCJ9.eyJpc3MiOiJnaXRodWIuY29tIiwiYXVkIjoicmF3LmdpdGh1YnVzZXJjb250ZW50LmNvbSIsImtleSI6ImtleTUiLCJleHAiOjE3Mzg5NzA1MjksIm5iZiI6MTczODk3MDIyOSwicGF0aCI6Ii8yMjEzMzc4NS8zODk0MjI2OTUtNGJjZmRjZWUtNzFiNC00MmQxLWE1Y2UtMmU4ZDAwNDBmZjFmLnBuZz9YLUFtei1BbGdvcml0aG09QVdTNC1ITUFDLVNIQTI1NiZYLUFtei1DcmVkZW50aWFsPUFLSUFWQ09EWUxTQTUzUFFLNFpBJTJGMjAyNTAyMDclMkZ1cy1lYXN0LTElMkZzMyUyRmF3czRfcmVxdWVzdCZYLUFtei1EYXRlPTIwMjUwMjA3VDIzMTcwOVomWC1BbXotRXhwaXJlcz0zMDAmWC1BbXotU2lnbmF0dXJlPWJiMzIxZDgwZTMyMTVhYWFlNDIwYmNkMjNkODNlNGIxM2NmNDRkYjUzNDYyZWE0MzU2MmNjNjAwODNiODQwOTMmWC1BbXotU2lnbmVkSGVhZGVycz1ob3N0In0._nfFW2naObZAkJEe-tTtrBrEH1nCfxc3pFksV2P4qCg)